Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listening Post 2.0 #639

Merged

Conversation

DangerRevolution
Copy link
Contributor

@DangerRevolution DangerRevolution commented Jan 2, 2024

About the PR

  • Adds Syndicate pAI to keep the crew company.

  • Adds a Synthesiser as people asked for an instrument aboard the vessel

  • Adds a second voicemask to the station

  • Adds new Syndicate Fax Machine, that is unable to fax to Central Command (pending merge by VMSolidus)

  • Adds one-way handheld radio; where the crew aboard can receive messages (I'm open to remove this)

  • Lowers volume of the Syndicate Crew Monitoring Server as it is insanely deafening to be around with no other noise going on.

  • Listening Post now spawns in the same instance as the station, surrounded by debris.

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

image
image

printing
icon
idle
inserting
image

🆑 DangerRevolution and VMSolidus

  • Add: Adds pAI, one-way handheld radio, instrument and new fax machine to the Listening Post
  • Add: All Syndicate Operatives now spawn with a Cybersun Pen
  • Remove: Syndicate Listening Post Operative no longer requires whitelist
  • Add: Listening Post now spawns visible on IFF.
  • Add: The Listening Outpost has received significant improvements to its interiors. It's now a place I personally would feel comfortable working in-VMSolidus

@DebugOk
Copy link
Contributor

DebugOk commented Jan 2, 2024

I want to review the map changes before this gets merged, just an fyi to Colin

@Colin-Tel
Copy link
Contributor

This must be the listening post post-hotfix fix :trollface:

@DangerRevolution
Copy link
Contributor Author

This must be the listening post post-hotfix fix :trollface:

honestly this was something meant to be included earlier; I was just battling Visual Studio to stop starting maps I was saving

@DangerRevolution
Copy link
Contributor Author

DangerRevolution commented Jan 9, 2024

Colour of fax machine is temporary, gonna switch it back to the regular colour for now to keep up the "stolen from nanotrasen" theme.

@github-actions github-actions bot added Changes: Map Changes: Sprite Changes any png or json in an rsi labels Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

RSI Diff Bot; head commit e13d337 merging into 9b2d304
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Structures/Machines/syndicate_fax_machine.rsi

State Old New Status
icon Added
idle Added
inserting Added
printing Added

Edit: diff updated after e13d337

@github-actions github-actions bot added the Changes: C# Changes any cs files label Jan 14, 2024
@VMSolidus
Copy link
Contributor

I've added my new spawning mechanic for the Listening Outpost.
TODO: Also spawn in random debris, and change the name that the outpost appears as on the mass scanner.

VMSolidus
VMSolidus previously approved these changes Feb 11, 2024
Copy link
Contributor

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't think I should merge this myself without first seeing if Debug gives the okay for this. I've finished my own "review" of this PR, and subsequently performed as much cleanup of it as I could reasonably find. Followed by testing to verify that all features work as intended. I believe that this PR is ready to be merged.

Copy link
Contributor

@DebugOk DebugOk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big scary maths, will require a more in-depth review soon:tm:

@VMSolidus
Copy link
Contributor

The big scary maths are about to get even scarier tonight because I have to account for "Stations of Unusual Size". Which I'll do by creating a Constant which is compared against the station size, and then derive a factor that we can use to adjust the final spawning position. Without such a factor, the math breaks down for stations that are significantly larger or smaller than Edge(The reference station)

@DebugOk
Copy link
Contributor

DebugOk commented Feb 12, 2024

Sounds like a lot of work

@DebugOk DebugOk marked this pull request as draft February 12, 2024 21:15
@VMSolidus
Copy link
Contributor

Sounds like a lot of work

Not too bad really. Since my original reference station for making this block of calculus was Edge, I can literally use Edge as my Constant. All I have to do is load up the spawning script in debug mode, start the map as Edge, spawn the outpost, and record the AABB.Length for Edge. This'll be stored in the spawnrule component as a Constant. To get the Factor for the final position, I can take AABB.Length for the currently spawned station, and divide it by the Constant. That way if the station is either larger or smaller than Edge, it'll move the final position of the outpost by the percentage difference.

@VMSolidus VMSolidus marked this pull request as ready for review February 13, 2024 00:36
@VMSolidus
Copy link
Contributor

Since the outpost no longer actually needs its IFF console, I've replaced it with a mass media console.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Feb 13, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Feb 13, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Feb 22, 2024
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Feb 22, 2024
@VMSolidus
Copy link
Contributor

No meaningful changes today, just adding the new license stuff to the PR. Still entirely feature complete, still awaiting final review.

Copy link
Contributor

@DebugOk DebugOk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still disagree with some parts but at this point whatever, if tests pass it can be merged

@VMSolidus VMSolidus merged commit 2a195a6 into DeltaV-Station:master Mar 8, 2024
12 checks passed
DeltaV-Bot pushed a commit that referenced this pull request Mar 8, 2024
@DangerRevolution DangerRevolution deleted the listening-post-map-changes branch March 9, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Map Changes: Sprite Changes any png or json in an rsi S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants