-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Listening Post 2.0 #639
Listening Post 2.0 #639
Conversation
I want to review the map changes before this gets merged, just an fyi to Colin |
This must be the listening post post-hotfix fix |
honestly this was something meant to be included earlier; I was just battling Visual Studio to stop starting maps I was saving |
Colour of fax machine is temporary, gonna switch it back to the regular colour for now to keep up the "stolen from nanotrasen" theme. |
RSI Diff Bot; head commit e13d337 merging into 9b2d304 Resources/Textures/DeltaV/Structures/Machines/syndicate_fax_machine.rsi
|
I've added my new spawning mechanic for the Listening Outpost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I don't think I should merge this myself without first seeing if Debug gives the okay for this. I've finished my own "review" of this PR, and subsequently performed as much cleanup of it as I could reasonably find. Followed by testing to verify that all features work as intended. I believe that this PR is ready to be merged.
This reverts commit cbd0c58.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big scary maths, will require a more in-depth review soon:tm:
The big scary maths are about to get even scarier tonight because I have to account for "Stations of Unusual Size". Which I'll do by creating a Constant which is compared against the station size, and then derive a factor that we can use to adjust the final spawning position. Without such a factor, the math breaks down for stations that are significantly larger or smaller than Edge(The reference station) |
Sounds like a lot of work |
Not too bad really. Since my original reference station for making this block of calculus was Edge, I can literally use Edge as my Constant. All I have to do is load up the spawning script in debug mode, start the map as Edge, spawn the outpost, and record the AABB.Length for Edge. This'll be stored in the spawnrule component as a Constant. To get the Factor for the final position, I can take AABB.Length for the currently spawned station, and divide it by the Constant. That way if the station is either larger or smaller than Edge, it'll move the final position of the outpost by the percentage difference. |
Since the outpost no longer actually needs its IFF console, I've replaced it with a mass media console. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: VMSolidus <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: VMSolidus <[email protected]>
No meaningful changes today, just adding the new license stuff to the PR. Still entirely feature complete, still awaiting final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still disagree with some parts but at this point whatever, if tests pass it can be merged
About the PR
Adds Syndicate pAI to keep the crew company.
Adds a Synthesiser as people asked for an instrument aboard the vessel
Adds a second voicemask to the station
Adds new Syndicate Fax Machine, that is unable to fax to Central Command (pending merge by VMSolidus)
Adds one-way handheld radio; where the crew aboard can receive messages (I'm open to remove this)
Lowers volume of the Syndicate Crew Monitoring Server as it is insanely deafening to be around with no other noise going on.
Listening Post now spawns in the same
instance
as the station, surrounded by debris.I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
🆑 DangerRevolution and VMSolidus